Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: DisallowedDeclarationName #215

Open
a-frantz opened this issue Oct 9, 2024 · 1 comment
Open

New rule: DisallowedDeclarationName #215

a-frantz opened this issue Oct 9, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@a-frantz
Copy link
Member

a-frantz commented Oct 9, 2024

Credit to @adthrasher for the idea proposed in a comment on #133

We have DisallowedInputName and DisallowedOutputName. Those should remain unchanged, but there should be a new rule that checks all Decls (IO and private) for "type prefixes/suffixes". e.g. File gtfffile would be bad and so would Int my_int

@a-frantz a-frantz added enhancement New feature or request good first issue Good for newcomers labels Oct 9, 2024
@adthrasher
Copy link
Member

One consideration (via Mike Rusch), what about something like bcftools annotate (https://samtools.github.io/bcftools/bcftools.html#annotate). It has parameters that can be specified as a string or as a file. So the file suffix might make sense in that case to distinguish.

-r, --regions chr|chr:pos|chr:from-to|chr:from-[,…​]
see [Common Options](https://samtools.github.io/bcftools/bcftools.html#common_options)

-R, --regions-file file
see [Common Options](https://samtools.github.io/bcftools/bcftools.html#common_options)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants