Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all the profile specific logic #2237

Open
airenzp opened this issue Oct 14, 2024 · 1 comment
Open

Document all the profile specific logic #2237

airenzp opened this issue Oct 14, 2024 · 1 comment
Assignees

Comments

@airenzp
Copy link
Collaborator

airenzp commented Oct 14, 2024

Document the profile settings related to the filters, as suggested by @siosonel

@airenzp airenzp self-assigned this Oct 14, 2024
@siosonel
Copy link
Member

Not urgent. Can follow the pattern in configs of other plots, where it's clear what the available options are. Something like this in js:

        countryTW: undefined,  // { id: 'Fcountry' || 'Acountry' },
	regionTW: undefined, // { id: 'FWHO_region' || 'AWHO_region' },
	...

or even better, convert to using typescript

type ProfileSettings = {
        ....,
        countryTW?:  { id: 'Fcountry' || 'Acountry' },
	regionTW?: { id: 'FWHO_region' || 'AWHO_region' },
}


const localFilter: ProfileSettings = { ... }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants