You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I prepared PR #137 I noticed that DisplayContoller::new directly changes the RCC clock configuration. Any changes to the clock configuration at this point won't be reflected in the Clocks struct that is returned when CFGR::freeze is called.
While the changes are limited to PLLSAI, which isn't used by other peripherals at the moment, it would be better to handle all clock setup in rcc.rs.
DisplayController::new does select PLLSAI frequency to match the required pixel clock, which was probably the reason to combine LTDC and clock setup into a single function. But the same could be achieved by adding a pixel_clock(&self) -> Hertz getter to DisplayContig.
The text was updated successfully, but these errors were encountered:
While I prepared PR #137 I noticed that
DisplayContoller::new
directly changes the RCC clock configuration. Any changes to the clock configuration at this point won't be reflected in theClocks
struct that is returned whenCFGR::freeze
is called.While the changes are limited to PLLSAI, which isn't used by other peripherals at the moment, it would be better to handle all clock setup in
rcc.rs
.DisplayController::new
does select PLLSAI frequency to match the required pixel clock, which was probably the reason to combine LTDC and clock setup into a single function. But the same could be achieved by adding apixel_clock(&self) -> Hertz
getter toDisplayContig
.The text was updated successfully, but these errors were encountered: