You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RngExt::init enables the main PLL, if it isn't already enabled. There are no checks that the PLL multiplication/division factors are correct or that a valid clock is supplied to the PLL.
To improve this I would suggest to remove the PLL related code from init and change it to take a &Clocks argument. Clocks contains a pll48clk_valid field, which could be used to check that a valid clock is supplied to the RNG.
The text was updated successfully, but these errors were encountered:
RngExt::init
enables the main PLL, if it isn't already enabled. There are no checks that the PLL multiplication/division factors are correct or that a valid clock is supplied to the PLL.To improve this I would suggest to remove the PLL related code from
init
and change it to take a&Clocks
argument.Clocks
contains apll48clk_valid
field, which could be used to check that a valid clock is supplied to the RNG.The text was updated successfully, but these errors were encountered: