Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note any significant distinctions between distutils and setuptools #22

Open
kristall opened this issue Sep 7, 2016 · 9 comments
Open

Comments

@kristall
Copy link

kristall commented Sep 7, 2016

Aloha,

"you’ll need to supply include_package_data=True to the setup() function."

/usr/local/lib/python3.4/distutils/dist.py:260: UserWarning: Unknown distribution option: 'include_package_data'
warnings.warn(msg)

It seems that (at least with python3) this option is no longer available.

@merwok
Copy link

merwok commented Sep 7, 2016

This works if your setup.py uses the setup function from setuptools, not distutils. Are the instructions clear on that point?

@kristall
Copy link
Author

kristall commented Sep 7, 2016

Ah, thanks for the hint. Imho the instructions are not clear on that point (especially if you just look at adding non-code files page).

@storborg
Copy link
Owner

storborg commented Sep 7, 2016

Thanks for the heads up. I'll clarify this point and investigate the circumstances under which one might end up with setuptools vs ``distutils` on a given platform.

@kristall
Copy link
Author

kristall commented Sep 7, 2016

Thanks for your help and time guys.

@kristall kristall closed this as completed Sep 7, 2016
@storborg storborg changed the title Problem with Adding Non-Code Files Note any significant distinctions between distutils and setuptools Sep 7, 2016
@storborg
Copy link
Owner

storborg commented Sep 7, 2016

I'm going to leave this ticket open until I have a chance to update that.

@storborg storborg reopened this Sep 7, 2016
@kristall
Copy link
Author

kristall commented Sep 7, 2016

That is, of course, your prerogative.

@kristall
Copy link
Author

kristall commented Sep 7, 2016

So if you want to mention any significant distinction, then let me mention also that: /usr/local/lib/python3.4/distutils/dist.py:260: UserWarning: Unknown distribution option: 'install_requires'
warnings.warn(msg)

@storborg
Copy link
Owner

storborg commented Sep 7, 2016

Good to know, thanks. I'm actually leaning towards advising "don't use distutils at all, here's how to use setuptools..."

@kristall
Copy link
Author

Well after having that warnings I tend to agree with you. But be sure to mention it on every side, since when you search stuff you don't always start reading at the frontpage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants