Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The CJS build of Vite's Node API is deprecated. #49

Open
gangsthub opened this issue Sep 27, 2024 · 0 comments · May be fixed by #51
Open

[Bug] The CJS build of Vite's Node API is deprecated. #49

gangsthub opened this issue Sep 27, 2024 · 0 comments · May be fixed by #51
Labels
bug Something isn't working

Comments

@gangsthub
Copy link

Describe the bug

See storybookjs/storybook#26291 (comment)

In order to remove this warning from the Storybook logs, this addon needs to update itself. It was fixed in a dependency of @storybook/addon-coverage called vite-plugin-istanbul and it's published after [email protected]. Current version of this package is 6.0.2, but refer to the releases to get a more updated info: https://github.com/iFaxity/vite-plugin-istanbul/releases

This is what we have at the moment of writing the issue description:

> yarn why vite-plugin-istanbul
<
└─ @storybook/addon-coverage@npm:1.0.4
   └─ vite-plugin-istanbul@npm:3.0.4 (via npm:^3.0.1)

Steps to reproduce the behavior

  1. Install storybook and add this addon
  2. Run SB
  3. See the The CJS build of Vite's Node API is deprecated. warning mentioned in [Bug]: Vite CJS warning still present in v8 RC storybook#26291

Expected behavior

The addon should be ESM-compatible and avoid using CJS version of Vite, before it's deprecated, and use the latest vite-plugin-istanbul or an alternative package that is compatible with ESM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant