Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the config.toml docs #1151

Open
Pdzly opened this issue Sep 17, 2024 · 0 comments
Open

Typo in the config.toml docs #1151

Pdzly opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@Pdzly
Copy link

Pdzly commented Sep 17, 2024

Summary

There is a typo in the docs.

# Due to conflicts between CORS and XSRF, if `server.enableXsrfProtection` is
# on and `server.enableCORS` is off at the same time, we will prioritize
# `server.enableXsrfProtection`.

It should say

# Due to conflicts between CORS and XSRF, if `server.enableXsrfProtection` is
# on and `server.enableCORS` is **ON** at the same time, we will prioritize
# `server.enableXsrfProtection`.

It would make no sense if they have conflicts between CORS and XSRF and if only one of them is activated ( so there is no conflict ).

@Pdzly Pdzly added bug Something isn't working needs triage labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant