Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-18532: [Enhancement] Support reading config options from file in Function Java Runner (JavaInstanceStarter) #5142

Open
2 tasks done
sijie opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels

Comments

@sijie
Copy link
Member

sijie commented Nov 18, 2022

Original Issue: apache#18532


Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Currently the JavaInstanceStarter uses JCommander to parse command line args. However in certain cases reading from command line is not very flexible (think we need to use a env var as an argument but the container has no shell access). Thus we need to support reading configs from a file.

This is necessary for :

BTW, we can provide a new issue for python as well.

Solution

Solution:

  • add a new command line flag "--config_file" and accepts a file URl
  • read the file using PulsarConfigurationLoader and create a new class JavaInstanceConfiguration extends PulsarConfiguration.
  • Config priority : command line > conf file.
  • Create a new validation class the make sure required field are either provided in the file or via command line interface (this means we need to make all JCommander required field non-required)

We need to make sure this new feature would not break any existing code.

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@imaffe imaffe self-assigned this Nov 21, 2022
@sijie sijie added the Stale label Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants