Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify PR template text #3630

Open
spotlesscoder opened this issue Oct 4, 2024 · 3 comments
Open

Minify PR template text #3630

spotlesscoder opened this issue Oct 4, 2024 · 3 comments

Comments

@spotlesscoder
Copy link
Collaborator

spotlesscoder commented Oct 4, 2024

Is it really necessary to ask for these things?

Dictionary: _dictionary_

Description
description of change

The dictionary can be determined from the changed file path
The description should be in the commit message

@spotlesscoder
Copy link
Collaborator Author

spotlesscoder commented Oct 14, 2024

@Jason3S what do you think?

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 16, 2024

@spotlesscoder,

Good question. The template can be annoying at times.

The dictionary can be determined from the changed file path

It is useful to know what dictionary / dictionaries they are trying to update and why. Most of the times I approve the PR from my phone and the file path is not immediately apparent.

The description should be in the commit message

I'm trying to avoid having to guess what the contributor has intended. They do not always add useful information to the commit message. Most of the time the commit message is just the name of the file.

In any case, I won't block a PR because the template is not fully filled in.

@spotlesscoder
Copy link
Collaborator Author

Maybe the affected dictionaries can be added in a comment by a bot running on a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants