-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify PR template text #3630
Comments
@Jason3S what do you think? |
Good question. The template can be annoying at times.
It is useful to know what dictionary / dictionaries they are trying to update and why. Most of the times I approve the PR from my phone and the file path is not immediately apparent.
I'm trying to avoid having to guess what the contributor has intended. They do not always add useful information to the commit message. Most of the time the commit message is just the name of the file. In any case, I won't block a PR because the template is not fully filled in. |
Maybe the affected dictionaries can be added in a comment by a bot running on a PR? |
Is it really necessary to ask for these things?
The dictionary can be determined from the changed file path
The description should be in the commit message
The text was updated successfully, but these errors were encountered: