Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Janus 1.x #280

Closed
fancycode opened this issue Jun 20, 2022 · 12 comments
Closed

Test with Janus 1.x #280

fancycode opened this issue Jun 20, 2022 · 12 comments

Comments

@fancycode
Copy link
Member

There seem to be problems when running against Janux 1.x, see #279.

@fancycode fancycode changed the title Support Janus 1.x Test with Janus 1.x Jun 20, 2022
@fancycode
Copy link
Member Author

Not a problem with 1.x according to #279, still should be tested though.

@brknkfr
Copy link

brknkfr commented Sep 29, 2022

I just tested nextcloud-spreed-signaling on a newly installed Debian system (Bullseye) with janus version 1.x (actually 1.0.1-1~bpo11+1 from the bullseye-backports) and it seems to work just fine.

@muchachagrande
Copy link

I've been using 1.x versions of Janus for some time and I can confirm that is working as with 0.x versions.
I'm using this docker to run Janus: mwalbeck/janus-gateway. It is always updated to the last Meetecho version.

@muchachagrande
Copy link

muchachagrande commented Jun 15, 2023

Hi, I've just fallen into a problem related with Talk for Android. Since then (version 15.1.1 and beyond) there were no video calls when using signaling server.
Yesterday I took the time to try to debug the problem and I found that it was a Janus version problem.
Since version 1.x Janus supports multi stream peer connections and it works with some differences than the 0.x versions that are still maintained in parallel.
The problem is described on this issue meetecho/janus-gateway#2566
Nextcloud Talk expects that the data channel to receive control messages from is labeled "JanusDataChannel", but in the multistream version they must include the participant ID in the label in order to identify who the data comes from.
So, with the multistream version the data channel is not JanusDataChannel anymore causing that Talk complains about receiving "Unknown message from 1 datachannel". The "1" is the label of the data channel and is not a known label to Talk.
Now that I've tested with a Janus version 0.x I can confirm that there are no more Unknown Messages received and Talk Android works again.

@wargreen
Copy link

Hi,
I've just setup the signaling server for our NC instance.
Janus 0.x don't seem to be anymore in the debian's repos.
Is it any news about the issue ? Or any workaround on debian-based distro ?

Thank you

@fancycode
Copy link
Member Author

Looks like no changes are necessary to support Janus 1.x in the signaling server itself.

See the following Talk-related issues for changes necessary in clients using the signaling server / Janus:

@mircokam
Copy link

mircokam commented Mar 16, 2024

Hello,
we testet the Android App Talk Version 18.1.0 on Pixel 7 with Janus 1.x Multistream an Nextcloud 28.0.3 and Talk 18.0.5 and nextcloud-spreed-signaling 1.2.3 an it works now with video. :-)

sunweaver/nextcloud-high-performance-backend-setup#109

@muchachagrande
Copy link

Did you test a video call from android to android ?

@mircokam
Copy link

mircokam commented Mar 17, 2024

I tested now android to android and at first, the camera streams aren't transmitted between the android devices (they are transmitted on/to iOS and in/to the Web). To transmit them, you have to disable and reenable the camera on both android devices in the video call. After that it works fine. I also found your issue describing the problem.

nextcloud/talk-android#3358 (comment)

@muchachagrande
Copy link

Ok... I was wondering if the upgrade of HPB would solve that issue, but it is not the case... thank you

@fancycode
Copy link
Member Author

Ok... I was wondering if the upgrade of HPB would solve that issue, but it is not the case... thank you

All these issues are purely client side, see #280 (comment) for the PRs in the client apps to support Janux 1.x. If you still experience (other) problems, please open a new issue in the related app repository.

@muchachagrande
Copy link

Hi @fancycode.

If you still experience (other) problems, please open a new issue in the related app repository.

There is an already opened issue for the referenced problem in the proper repository.

Thank you and cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants