Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the future of this project? #494

Open
pvasek opened this issue Sep 16, 2023 · 5 comments
Open

What is the future of this project? #494

pvasek opened this issue Sep 16, 2023 · 5 comments

Comments

@pvasek
Copy link
Collaborator

pvasek commented Sep 16, 2023

Hi guys, as you could probably notice. I don't have time and interest to work on it anymore.

As @jrolfs correctly mentioned in PR #473, obviously this project is stalled out.

Is there anyone who is using this project and is interested in becoming a maintainer?

Options:

  1. Take over this project
  2. Create a fork

I guess option 1 would be easier for all who already using it. But there can be a tricky part with transferring npm package rights. Not technically but of course, I would have to trust this guy before doing so.

Option 2 is much easier in this case. I would just update the readme of this project pointing to the new one and that's it.

What are your opinions about it?

@jrolfs
Copy link

jrolfs commented Oct 12, 2023

If I were using this project more actively right now, I'd probably volunteer to help with maintenance, but I worry I won't be able to prioritize it until I pick the work back up that leveraged this package.

I'll try to look into this, but does Storybook still use this package actively? I was thinking @chromaui might be a good steward for this project and if they are indeed still using it in Storybook, they'd have a vested interest in keeping things going here.

Also, I just want to say thank you again for your contribution to open source with this project @pvasek. Well done with the structure of this codebase :)

@pwolfert
Copy link
Contributor

pwolfert commented May 29, 2024

Yeah, I'm also curious if someone at Chromatic (@chromaui) would be interested in maintaining it. While I'm actively using this library right now, I'll be transitioning off the project that uses it over the next couple months. I do know that they've changed the Storybook default in v8 to use react-docgen, but people can still use react-docgen-typescript, and I imagine it's still going to be wildly popular for the foreseeable future. Thank you for all your work on this, @pvasek!

@pwolfert
Copy link
Contributor

Not trying to put either of you on the spot but just trying to get eyes on it: @zol or @domyen, would your org be interested in this?

@zol
Copy link

zol commented May 29, 2024

Hey @pwolfert, I don't code very much anymore but I'll get with @shilman over here to see how maintaining this aligns with our plans for Storybook

@pwolfert
Copy link
Contributor

I just noticed that at one point @shilman had published a fork of this on npm but that now the repo is archived. Any interested in reviving it and publishing some of the features and fixes in this repo from the past couple years, since you have the infrastructure to publish that package to npm?

hana-akamai added a commit to linode/manager that referenced this issue Aug 27, 2024
## Description 📝
Performance optimizations for running Storybook locally

The main culprit is using `react-docgen-typescript`; it's parsing every file for docgen info. The package is also [no longer being maintained](styleguidist/react-docgen-typescript#494) (the last release was in [end of 2021](https://github.com/styleguidist/react-docgen-typescript/releases)).
   - There's a faster docgen library that Storybook 8 uses, `react-docgen`, however we're missing a lot of typing by using that since it's using a shallower analysis.
   - The solution I ended up at was to keep `react-docgen-typescript`, but tighten the scope on what files are parsed for the docgen (Components and Features only). And to also disable `allowSyntheticDefaultImports` and `esModuleInterop` per the [Storybook MUI docs
](https://storybook.js.org/recipes/@mui/material#4-use-material-ui-prop-types-for-better-controls-and-docs)

The time from first paint to Intro loaded on my Intel i7 2019 MBP went from `over 1 minute` to `30s` 🎉 

## How to test 🧪
### Reproduction steps
(How to reproduce the issue, if applicable)
- On the develop branch, run Storybook locally and time the time it takes from first paint to Intro loaded

### Verification steps
(How to verify changes)
- Pull down this branch, run Storybook locally and the time from first paint to Intro loaded should be shorter than develop
- The should be no regressions in the typing and loading of stories compared to https://design.linode.com/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants