From 60e1768c0f6002c9feae0e499ff4efec22a369b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9F=D1=80=D0=B5=D0=B4=D1=80=D0=B0=D0=B3=20=D0=9D=D0=B8?= =?UTF-8?q?=D0=BA=D0=BE=D0=BB=D0=B8=D1=9B?= Date: Mon, 20 May 2024 17:35:36 +0200 Subject: [PATCH 1/3] remove logging.basicConfig() Avoid polluting other packages closes #2477 --- third_party/websocket_server/websocket_server.py | 1 - 1 file changed, 1 deletion(-) diff --git a/third_party/websocket_server/websocket_server.py b/third_party/websocket_server/websocket_server.py index 00ba508fe..0dd5e013a 100644 --- a/third_party/websocket_server/websocket_server.py +++ b/third_party/websocket_server/websocket_server.py @@ -15,7 +15,6 @@ from socketserver import ThreadingMixIn, TCPServer, StreamRequestHandler logger = logging.getLogger(__name__) -logging.basicConfig() ''' +-+-+-+-+-------+-+-------------+-------------------------------+ From 17ae2522aae4a8e5c13d1b7399ab148d06c56176 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9F=D1=80=D0=B5=D0=B4=D1=80=D0=B0=D0=B3=20=D0=9D=D0=B8?= =?UTF-8?q?=D0=BA=D0=BE=D0=BB=D0=B8=D1=9B?= Date: Wed, 29 May 2024 19:17:44 +0200 Subject: [PATCH 2/3] Revert "remove logging.basicConfig()" This reverts commit 60e1768c0f6002c9feae0e499ff4efec22a369b8. --- third_party/websocket_server/websocket_server.py | 1 + 1 file changed, 1 insertion(+) diff --git a/third_party/websocket_server/websocket_server.py b/third_party/websocket_server/websocket_server.py index 0dd5e013a..00ba508fe 100644 --- a/third_party/websocket_server/websocket_server.py +++ b/third_party/websocket_server/websocket_server.py @@ -15,6 +15,7 @@ from socketserver import ThreadingMixIn, TCPServer, StreamRequestHandler logger = logging.getLogger(__name__) +logging.basicConfig() ''' +-+-+-+-+-------+-+-------------+-------------------------------+ From b6bd450b671335a0a7b4f695058b1212af4bf3d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9F=D1=80=D0=B5=D0=B4=D1=80=D0=B0=D0=B3=20=D0=9D=D0=B8?= =?UTF-8?q?=D0=BA=D0=BE=D0=BB=D0=B8=D1=9B?= Date: Wed, 29 May 2024 19:22:23 +0200 Subject: [PATCH 3/3] add comments --- third_party/websocket_server/websocket_server.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/third_party/websocket_server/websocket_server.py b/third_party/websocket_server/websocket_server.py index 00ba508fe..1597a79b2 100644 --- a/third_party/websocket_server/websocket_server.py +++ b/third_party/websocket_server/websocket_server.py @@ -15,7 +15,9 @@ from socketserver import ThreadingMixIn, TCPServer, StreamRequestHandler logger = logging.getLogger(__name__) -logging.basicConfig() +# This line installed a root logger, which results in duplicate log entries. +# For more details, see: https://github.com/sublimelsp/LSP/issues/2477 +# logging.basicConfig() ''' +-+-+-+-+-------+-+-------------+-------------------------------+