From 7d2dc7e5c400546d036bdf95600368384208d0eb Mon Sep 17 00:00:00 2001 From: Daniel Raap Date: Tue, 7 May 2024 17:57:14 +0200 Subject: [PATCH] sophora-admin-dashboard: Don't render `annotations` for Service if empty (#90) * sophora-admin-dashboard: Don't render `annotations` for Service if empty * remove manual line break --------- Co-authored-by: Philip Dakowitz --- charts/sophora-admin-dashboard/Chart.yaml | 2 +- charts/sophora-admin-dashboard/templates/service.yaml | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/charts/sophora-admin-dashboard/Chart.yaml b/charts/sophora-admin-dashboard/Chart.yaml index 0a5213d..0c0810c 100644 --- a/charts/sophora-admin-dashboard/Chart.yaml +++ b/charts/sophora-admin-dashboard/Chart.yaml @@ -9,4 +9,4 @@ maintainers: # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 1.2.0 +version: 1.2.1 diff --git a/charts/sophora-admin-dashboard/templates/service.yaml b/charts/sophora-admin-dashboard/templates/service.yaml index 55ed559..72611e4 100644 --- a/charts/sophora-admin-dashboard/templates/service.yaml +++ b/charts/sophora-admin-dashboard/templates/service.yaml @@ -4,7 +4,9 @@ metadata: name: {{ include "sophora-admin-dashboard.fullname" . }} labels: {{- include "sophora-admin-dashboard.labels" . | nindent 4 }} - annotations: {{- toYaml .Values.service.annotations | nindent 4 }} + {{- with .Values.service.annotations }} + annotations: {{- toYaml . | nindent 4 }} + {{- end }} spec: type: {{ .Values.service.type }} {{ if .Values.service.clusterIP -}}