Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra " in L402 challenge headers? #10

Closed
positiveblue opened this issue May 18, 2024 · 1 comment
Closed

Extra " in L402 challenge headers? #10

positiveblue opened this issue May 18, 2024 · 1 comment

Comments

@positiveblue
Copy link

This library tries to (rightly!) match the formant from the spec draft

402 macaroon="{macaroon}", invoice="{invoice}"

However, I think this is a typo in the draft we should go with the version without the " surrounding the string values.

Your input is very much welcomed in the spec discussion 👍

@SamuelAl
Copy link
Contributor

SamuelAl commented May 20, 2024

Hi @positiveblue , thanks for mentioning this! I added my response to the L402 BLIP draft here

TLDR: I think you are referring to two different things. The WWW-Authenticate header does typically enclose values in double quotes as can be seen in other auth schemes (more details in the BLIP draft). I therefore think that it is correct to also use them in the L402 challenge header, as is specified in the L402 spec.

Happy to continue the conversation in the BLIP draft, but since the current functionality is in keeping with the spec I will close the issue for now. We can always reopen it depending on the decision arrived to in the draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants