Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations in example gallery do not animate #721

Open
wtbarnes opened this issue Jun 9, 2024 · 1 comment
Open

Animations in example gallery do not animate #721

wtbarnes opened this issue Jun 9, 2024 · 1 comment
Labels
Documentation Affects the documentation. help wanted

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Jun 9, 2024

There is at least one example gallery entry that shows a resulting animation (https://docs.sunpy.org/projects/ndcube/en/latest/generated/gallery/creating_even_spaced_wavelength_visualisation.html#sphx-glr-generated-gallery-creating-even-spaced-wavelength-visualisation-py), but that animation is not actually animated in the rendered example gallery. To enable this, we should be setting the following config option in the sphinx gallery config as in sunpy,

https://github.com/sunpy/sunpy/blob/a986291976a7e250924197455f09630847706824/docs/conf.py#L28

@wtbarnes wtbarnes added bug Documentation Affects the documentation. labels Jun 9, 2024
@wtbarnes
Copy link
Member Author

wtbarnes commented Jun 9, 2024

Ok, I need to take that back. It looks like that config option is already enabled and it appears to be down to the way the animation is being displayed. In the sunpy case, the things being displayed are matplotlib FuncAnimation objects. Maybe it is just a matter of returning that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Affects the documentation. help wanted
Projects
None yet
Development

No branches or pull requests

2 participants