Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TSV download issues #43

Open
justincorrigible opened this issue Dec 1, 2021 · 0 comments
Open

Resolve TSV download issues #43

justincorrigible opened this issue Dec 1, 2021 · 0 comments
Assignees

Comments

@justincorrigible
Copy link
Member

As part of the implementation we've encountered a bug in which pressing any of the two default tsv download options causes a critical error in the API.

Upon further inspection, turns out the issue is Arranger was customised for a cancer-file-centric model, which included specific fields that caused errors when missing.

This ticket adds code guards and updates the UI to use the improved arranger version.


bonus: As per conversation with @joneubank, we're adding a default "max rows" value for these, as large numbers may overwhelm the servers and potentially enable unintentional DDoS by insistent users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant