From 0896a4adc0d17d17f1f4c249305b78666f0d9418 Mon Sep 17 00:00:00 2001 From: FritzSF Date: Tue, 24 Sep 2024 14:24:03 +0200 Subject: [PATCH 1/4] [NHUB-558] sort by dropdown is below save new topic bar --- assets/styles/agenda.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/styles/agenda.scss b/assets/styles/agenda.scss index 28787a3f5..0d524cfba 100644 --- a/assets/styles/agenda.scss +++ b/assets/styles/agenda.scss @@ -46,7 +46,7 @@ } .navbar.navbar--search-results { - z-index: 1; + z-index: 2; grid-row: 2 / 3; } From 026555bd8ff566bb780845963854c6e24c627673 Mon Sep 17 00:00:00 2001 From: FritzSF Date: Fri, 4 Oct 2024 16:06:52 +0200 Subject: [PATCH 2/4] [NHUB-562] Checkmark is missing when items are selected for bulk actions --- assets/styles/form-elements.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/assets/styles/form-elements.scss b/assets/styles/form-elements.scss index 4b79a41e3..cf76ab19b 100644 --- a/assets/styles/form-elements.scss +++ b/assets/styles/form-elements.scss @@ -66,10 +66,11 @@ inset-inline-start: 16%; width: 1rem; height: .5rem; - border: .16rem solid #64646466; + border: .16rem solid hsla(0, 0%, 0%, 0.3); border-block-start: none; border-inline-end: none; background: rgba(0, 0, 0, 0); + transition: all 0.3s ease; } } } From 37e02944c341c607de2370d2497bc0908d1fb401 Mon Sep 17 00:00:00 2001 From: FritzSF Date: Tue, 29 Oct 2024 16:38:38 +0100 Subject: [PATCH 3/4] [STTNHUB-371] Newshub Agenda: Some UI elements displayed over filter dropdown menus --- assets/styles/agenda.scss | 2 +- assets/styles/article-list.scss | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/assets/styles/agenda.scss b/assets/styles/agenda.scss index 0d524cfba..c80dddba4 100644 --- a/assets/styles/agenda.scss +++ b/assets/styles/agenda.scss @@ -20,7 +20,7 @@ } .wire-column__main-header-container { position: relative; - z-index: 1; + z-index: 2; background-color: var(--main-header-color-bg); box-shadow: 0 3px 6px hsla(0, 0%, 0%, 0.1), 0 1px 0 hsla(0, 0%, 0%, 0.06); gap: 0; diff --git a/assets/styles/article-list.scss b/assets/styles/article-list.scss index 30ccc9d7e..b7cc5d839 100644 --- a/assets/styles/article-list.scss +++ b/assets/styles/article-list.scss @@ -130,15 +130,13 @@ margin-block-start: 0; overflow: auto; flex-grow: 1; + z-index: 1; // Z-index fix for Chrome } - - .wire-articles__item-sidebar { margin-inline-end: var(--space--2); } - // STATES .wire-articles__item--covering { &:before { From 03302277940548e3a6bfcfbce890405e27574cab Mon Sep 17 00:00:00 2001 From: FritzSF Date: Thu, 7 Nov 2024 15:32:46 +0100 Subject: [PATCH 4/4] CSS optimisation --- .../SearchResultsAdvancedSearchRow.tsx | 2 +- assets/styles/agenda.scss | 4 ++-- assets/styles/search-results.scss | 11 ++++++++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/assets/search/components/SearchResultsBar/SearchResultsAdvancedSearchRow.tsx b/assets/search/components/SearchResultsBar/SearchResultsAdvancedSearchRow.tsx index 2839eb5b1..b8c3596e7 100644 --- a/assets/search/components/SearchResultsBar/SearchResultsAdvancedSearchRow.tsx +++ b/assets/search/components/SearchResultsBar/SearchResultsAdvancedSearchRow.tsx @@ -162,7 +162,7 @@ export function SearchResultsAdvancedSearchRow({ secondary={true} title={gettext('inside')} > -
+
{(Object.keys(fieldNameToLabel) as Array) .filter((fieldName) => availableFields.includes(fieldName)) .map((fieldName) => ( diff --git a/assets/styles/agenda.scss b/assets/styles/agenda.scss index c80dddba4..3c25817f0 100644 --- a/assets/styles/agenda.scss +++ b/assets/styles/agenda.scss @@ -26,8 +26,8 @@ gap: 0; flex-shrink: 0; display: grid; - grid-template-rows: auto auto 1fr auto; - max-height: clamp(360px, 50svh, 50svh); + grid-template-rows: auto auto auto auto; + max-height: clamp(320px, 50svh, 50svh); @include phone { .search-result__tags-list { border-bottom: 2px solid var(--main-header-color-bg); diff --git a/assets/styles/search-results.scss b/assets/styles/search-results.scss index 28f7ed6f0..9ade8b8fc 100644 --- a/assets/styles/search-results.scss +++ b/assets/styles/search-results.scss @@ -69,16 +69,20 @@ .search-result__tags-list-row { display: flex; flex-direction: row; - padding-block: 12px; + padding-block: var(--space--0-5); gap: var(--space--2); - min-height: 56px; - border-block-start: 1px dashed hsla(0, 0%, 20%, 0.2); + //min-height: 56px; + //border-block-start: 1px dashed hsla(0, 0%, 20%, 0.2); flex-shrink: 0; &:first-child { border: none; } + &:last-child { + padding-block-end: var(--space--1-5); + } .tags-list { flex-grow: 1; + gap: var(--space--0-5); } .search-result__tags-list-row-label { display: inline-flex; @@ -121,6 +125,7 @@ z-index: 1; background-color: var(--search-result-tags-list-color-bg); box-shadow: inset 0 1px 3px -2px hsla(0, 0%, 0%, 0.2); + padding-block-start: var(--space--1-5); } } .tags-list-row__button-group {