Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor][SuperReader][Quill] - Make it easier to apply indentations during deserialization #2351

Open
matthew-carroll opened this issue Sep 26, 2024 · 0 comments
Labels
area_quill area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less

Comments

@matthew-carroll
Copy link
Contributor

Various nodes support indent. Indents need to be serialized and deserialized, e.g., in the Quill format with the "indent" property.

Currently, when deserializing a Quill delta with an indent, we have to submit 1+ indent requests to the editor. There are two aspects of this that are unnecessary:

  1. If we know we need to indent to level 3, we should be able to do that with a single request, instead of 3 requests
  2. If we know the indent when creating the node, we should be able to pass that into the request to create the node

Verify the reasonableness of the above changes, and if they're reasonable, then make those changes.

@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less area_super_reader Related to SuperReader area_quill labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_quill area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 1 1hr or less
Projects
None yet
Development

No branches or pull requests

1 participant