Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow binding to const with spread in legacy mode #13849

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

paoloricciuti
Copy link
Member

Before submitting the PR, please make sure you do the following

Closes #13844...initially i wanted to prevent binding when the binder was in legacy mode but this

<script>
    import A from "./A.svelte";
    let x = $state();
</script>

<A
    bind:x
/>
{x}

works and we can't change it without a breaking (svelte 6 wen?) so disallow this

```svelte
<script>
    import A from "./A.svelte";
    let x = $state();
</script>

<A
    bind:x
    {...{}}
/>
{x}

seems weird.

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 0dd2125

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm merged commit 04c38b0 into main Oct 24, 2024
7 checks passed
@trueadm trueadm deleted the binding-cost-legacy-spread branch October 24, 2024 12:21
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding to an exported constant while passing $$restProps fails
2 participants