Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte:head does not remove title tag #7656

Open
mallsoft opened this issue Jul 4, 2022 · 2 comments · May be fixed by #14116
Open

svelte:head does not remove title tag #7656

mallsoft opened this issue Jul 4, 2022 · 2 comments · May be fixed by #14116

Comments

@mallsoft
Copy link

mallsoft commented Jul 4, 2022

Describe the bug

A title tag added using <svelte:head>, cannot be removed? like you can with any other tag i have tested (meta, script).

Reproduction

<svelte:head>
	{#if toggleBool}
	<!-- stays put even if toggleBool is false  -->
		<title>Title injected!!!</title>

	<!-- gets removed as expected  -->
		<meta name="description" content="I am ALIVE" />

	<!-- gets removed as expected  -->
		<script>
			console.log('I am alive!');
		</script>
	{/if}
</svelte:head>

Relevant repl: https://svelte.dev/repl/2ecf81b43d0d4b2eaa02d80adf803929?version=3.48.0

Logs

No response

System Info

Windows 10, Firefox & Edge, svelte repl 3.48.0

Severity

annoyance
@pedeEli
Copy link

pedeEli commented Jul 6, 2022

I think thats on purpose, because when you would remove the title, without setting a new one the page would have no title at all. So the only way to change the title is to set a new one.
You could of cause keep track of the previeous titles and set it to the last one. This could be a possible solution

@UnlimitedBytes
Copy link

This actually blocks fallback titles, maybe we can (at least) remove the title when one is present in a parent, like:

<!-- src/routes/+layout.svelte -->
<svelte:head>
  <title>Fallback</title>
</svelte:head>
<!-- src/routes/+page.svelte -->
<svelte:head>
  <title>Home</title>
</svelte:head>

<a href="/404">Go to 404 page</a>

Give the above example a direct call to "/404" will result in the title "Fallback" while a call using CSR will result in the old title "Home" still being displayed instead of the fallback one.

@Conduitry Conduitry mentioned this issue Jun 9, 2023
Closed
dummdidumm added a commit that referenced this issue Nov 2, 2024
@dummdidumm
fix: reset title element to previous value on removal
c9f5147 
fixes #7656
This was referenced Nov 2, 2024
Draft
Closed
@Rich-Harris Rich-Harris mentioned this issue Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset title element to previous value on removal sveltejs/svelte
3 participants
@mallsoft @UnlimitedBytes @pedeEli