-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assets #24
Comments
Merged
This was referenced Oct 7, 2021
Merged
Merged
Merged
Merged
This was referenced Oct 20, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to create the assets entity.
Assets is a list of symbols, each one of them representing an "asset" - this is a group of coins or tokens of the same value, that can be easily exchanged between each other at 1:1 ration (minus commision), reside on differrent networks, and can be grouped under the same symbol/logo of original value.
This is one way to do it:
These assets need to be configured in the /assets/ folder (same level as /networks/ folder) in the root repo directory.
Trustwallet has assets under the network folder, but i didnt notice the connection between the cross-network assets such as "USDC", "USDT", etc other than the symbol name.
Thing is symbol names may not match in some cases. They could be different in different networks.
For example, BTC has a different symbol in Ethereum - its WBTC, however, some CLIents show this as BTC in ethereum too. So we need to let the user decide what network and symbol he wants to choose as his underlying coin or token on selected network.
The assets will become the grouping key for different wallets on different networks. And even tokens of the same value on the same network can be grouped together... e.g. renBTC, WBTC, bBTC, etc etc..
Now its hard to decide which of these assets need to belong to the BTC group. The primary trait that will lead to grouping to the BTC asset shall be the exchange rate. The exchange rate of BTC should be identical of the primary BTC coin... So if this rate is different, the token should not be grouped under the same asset. There could be discrepancies in the rate, like eth's WBTC and BTC have very similar price, but nevertheless i have seen them differ by 1%.
On the other hand there are two currencies that are of the same value, nevertheless these are different assets:
USDC, USDT. They too have representations in multiple networks. These are two different assets because they are stable coins and they are controlled by 2 different entities and have a different logo.
The text was updated successfully, but these errors were encountered: