-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal import instead of implementationOnly import #5109
base: main
Are you sure you want to change the base?
Conversation
@swift-ci test |
Looks like we have something else to sort out here... |
Can I also make the request to get this cherrypicked to 6.0 (and even 6.0.2) if possible? |
cc @xymus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this will break Foundation on Windows. the @_implementationOnly
import does not require the client to see the CoreFoundation module, while internal import
does. We do not ship the CoreFoundation interface (headers) on Windows as per the request from the initial port. If we need to start shipping them, we need to ensure that the driver, installer, and SPM are updated to correctly handle this.
I had the same concern as @compnerd - unfortunately |
Use
internal import CoreFoundation
instead of@_implementationOnly import CoreFoundation
. Resolves #5108