Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money precision needs to accept less than 2 decimal places #56

Closed
stevie-mayhew opened this issue Jun 13, 2014 · 3 comments
Closed

Money precision needs to accept less than 2 decimal places #56

stevie-mayhew opened this issue Jun 13, 2014 · 3 comments

Comments

@stevie-mayhew
Copy link
Member

Currencies such as Japanese Yen have no decimal place, currently the lower bound on decimal places is set to 2 (

if($shopConfig && $shopConfig->BaseCurrencyPrecision > 2) {
).

@silverstripe-elliot
Copy link

Cheers, I'll patch it up tonight. Ideally it should match up with what Zend/Currency.php uses in the framework (it's bounded between -1 and 30). I'll still leave it as "2" by default for backwards compatibility

@stevie-mayhew
Copy link
Member Author

Awesome, thanks heaps @silverstripe-elliot

@silverstripe-elliot
Copy link

Pull request is here: #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants