Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No minimum receive amount or LSP fee, and CJIT Error when attempting to receive spending balances when network is down #1898

Closed
catch-21 opened this issue May 28, 2024 · 5 comments · Fixed by #2312
Assignees
Labels
bug Something isn't working estimate:5 triage This issue needs to be looked over by the team

Comments

@catch-21
Copy link
Contributor

Describe the bug

Created off the back of #1833 (comment)

$0 receive minimum, $0 LSP fee and CJIT Error: init_channel_manager or CJIT Error: Failed to create cjit entry. undefined toast is displayed when attempting to receive spending balance without an existing LN connection. We should handle this better in the UI, perhaps preventing progression when unable to contact LSP.

Reproduce

This is easy to reproduce in aeroplane mode but it can also occur when network is down or restricted

  1. With no existing LN connection
  2. Enable aeroplane mode to stop network
  3. Attempt to receive lightning funds
  4. Observe $0 minimum
  5. Continue
  6. Observe $0 LSP fee
  7. Continue
  8. Observe cjit error

Screenshots / Recording

Screenrecorder-2024-05-28-17-40-07-659.mp4

Operating system

Android 13 TKQ1.221114.001

Bitkit version

5dee7d2

Log output

No response

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels May 28, 2024
@catch-21 catch-21 changed the title [Bug]: No minimum or LSP fee and CJIT Error when attempting to receive spending balances when network is down [Bug]: No minimum receive amount or LSP fee and CJIT Error when attempting to receive spending balances when network is down May 28, 2024
@catch-21 catch-21 changed the title [Bug]: No minimum receive amount or LSP fee and CJIT Error when attempting to receive spending balances when network is down [Bug]: No minimum receive amount or LSP fee, and CJIT Error when attempting to receive spending balances when network is down May 28, 2024
@limpbrains limpbrains self-assigned this May 28, 2024
@JeanlChristophe
Copy link

Normaly you received a notification saying "network issue", right?

@catch-21
Copy link
Contributor Author

Normaly you received a notification saying "network issue", right?

Yes, but still...


Minimum is wrong and misleading.
Screenshot 2024-06-21 at 11 13 02


Service provider fee is wrong and misleading.
Screenshot 2024-06-21 at 11 13 36


"Wtf is CJIT" - User, probably.
Screenshot 2024-06-21 at 11 14 05

@limpbrains
Copy link
Collaborator

In flight mode it is now impossible to strart CJIT flow.
The "Spending Balance Initializing" spinner will never end

@catch-21
Copy link
Contributor Author

Tested on v1.0.4 6404b07

In flight mode it is now impossible to strart CJIT flow.
The "Spending Balance Initializing" spinner will never end

True, but if aeroplane mode (or network drop probably) after bitkit has already initialised it's same behaviour as before with the zero values.

Screenrecorder-2024-08-30-17-53-43-752.mp4

If we don't care enough then feel free to close off.

@catch-21
Copy link
Contributor Author

catch-21 commented Nov 4, 2024

Tested on v1.0.6 (138)
I'd say the original bug is fixed but now I get an error containing 'undefined'

Screenshot 2024-11-04 at 17 21 04
RPReplay_Final1730740699.mp4

Raised #2330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working estimate:5 triage This issue needs to be looked over by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants