Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Restored wallet splits Boosted CPFP transactions into separate activities #1844

Open
catch-21 opened this issue May 17, 2024 · 4 comments · May be fixed by #2128
Open

[Bug]: Restored wallet splits Boosted CPFP transactions into separate activities #1844

catch-21 opened this issue May 17, 2024 · 4 comments · May be fixed by #2128
Labels

Comments

@catch-21
Copy link
Contributor

catch-21 commented May 17, 2024

Describe the bug

When boosting a transaction, the existing activity is updated to reflect the change and combines the subtracted amounts. If the wallet is restored the transactions are displayed as separate activities. We should aim to keep the activity list constant after wallet restore.

Reproduce

  1. Send onchain funds using a fee rate that needs a boost
  2. Boost the transaction
  3. Observe the two transactions are combined in one activity
  4. Restore the wallet
  5. Observe the two transactions each now have their own activity

Screenshots / Recording

In the following example, the final transaction in the CPFP chain is d69eeb99e9a562e7b9a6a34abce3c77808e4e0f8a077058ee1558881ae209a2b

Before restore, two activities are shown for a chain of three transactions. The top one had a boost and so combines two CPFP transactions and the bottom is a single transaction:

Screenshot 2024-05-17 at 15 59 17

After restore there are three activities, one for each transaction in the CPFP chain:

Screenshot 2024-05-17 at 15 59 17

Operating system

Android 13 TKQ1.221114.001

Bitkit version

4980b42

Log output

No response

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team UX / design backup labels May 17, 2024
@JeanlChristophe
Copy link

@catch-21 It's what's on the current version of Figma, right?

@catch-21
Copy link
Contributor Author

I assume Figma is correct, in that multiple transactions are to always be grouped into a single activity.

@coreyphillips
Copy link
Collaborator

It's about intention. Bitkit loses that intent when we restore because it doesn't back up which transactions were boosted vs transactions that were sent-to-self. They are effectively the same thing, we just bundle boosted transactions together.

Potential solution. If we wanted to retain that intent and have boosted transactions bundled together on restore we would have to add boosted transactions to our backup flow and adjust the activity list UI accordingly during restore.

Personally, I'm against using backups for anything that is non-critical or UI-related as it adds a lot of complexity and increases the calls we need to make when reading/writing from backups. Therefore, I would argue that keeping the way it currently restores is an acceptable fallback instead of additional complexity.

@pwltr pwltr removed the triage This issue needs to be looked over by the team label Jul 25, 2024
@pwltr pwltr linked a pull request Aug 9, 2024 that will close this issue
7 tasks
@pwltr
Copy link
Collaborator

pwltr commented Aug 9, 2024

Draft PR here: #2128

There is currently an issue with restoring boosted transactions, onchain activity is restored before boosted transactions are in state. Will revisit after RBF is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants