Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Not always using unique onchain receive address #2078

Open
catch-21 opened this issue Jul 22, 2024 · 5 comments · May be fixed by #2340
Open

[Bug]: Not always using unique onchain receive address #2078

catch-21 opened this issue Jul 22, 2024 · 5 comments · May be fixed by #2340
Assignees
@pwltr
Labels
bug Something isn't working triage This issue needs to be looked over by the team

Comments

@catch-21
Copy link
Contributor

catch-21 commented Jul 22, 2024 •
edited
Loading

Describe the bug

My wallet has not always been using a new unique address for each onchain receive. The latest transaction I took is f23b28ed8e8d4faf942e37824994818163cf4aa7017ea6592d4e3e88fd36d461 and that is to address bc1qqraqjlu9wgxsm8fsf4n8anhyzlkfap0f7eefca, which currently has 11 transactions over the past 3 months. When I go to receive again the same address is suggested.

This was once also the case for bc1q7t9a52ygc8yucya7zm0ypyu4ys3sgay9pq2ecc

Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots / Recording

Screenshot 2024-07-22 at 13 05 28

Operating system

Android 13 TKQ1.221114.001

Bitkit version

v128

Log output

No response
@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Jul 22, 2024
@limpbrains limpbrains self-assigned this Jul 25, 2024
@JeanlChristophe JeanlChristophe added the high priority This should be worked on urgently label Aug 30, 2024
@limpbrains
Copy link
Collaborator

Do you still have this issue? It might be fixed in #2210

@pwltr
Copy link
Collaborator

pwltr commented Oct 2, 2024 •
edited
Loading

Looks like the onchain wallet is not refreshed somewhere:

  1. Create new wallet
  2. Receive onchain tx
  3. Open Receive again, check address
Simulator.Screen.Recording.-.iPhone.15.-.2024-10-02.at.12.23.11.mp4

Then if you pull to refresh you'll get a new address.

@catch-21
Copy link
Contributor Author

catch-21 commented Oct 5, 2024

I haven't seen this recently with receive address, but we have seen change address reuse in testing session.
I hope that those are both the same cause that Phil suggested.

@JeanlChristophe
Copy link

@catch-21 can you test it again in order to see if Ivan need to spend time on it, please?

@JeanlChristophe JeanlChristophe removed the high priority This should be worked on urgently label Nov 1, 2024
@pwltr pwltr self-assigned this Nov 5, 2024
@pwltr pwltr linked a pull request Nov 7, 2024 that will close this issue
Open
7 tasks
@pwltr
Copy link
Collaborator

pwltr commented Nov 7, 2024

Can easily reproduce this with a new wallet:

  1. Create new wallet
  2. Receive onchain tx (don't mine block)
  3. Open Receive again, check address
  4. Also observe no activity
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-07.at.15.40.21.mp4

Feels like this should be handled in beignet but fixed here in Bitkit for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwltr pwltr

Labels
bug Something isn't working triage This issue needs to be looked over by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(receive): refresh onchain wallet after receive synonymdev/bitkit
4 participants
@limpbrains @pwltr @JeanlChristophe @catch-21