Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Using cached/stale fee rate and block header data causes lightning issues #2352

Open
Jasonvdb opened this issue Nov 15, 2024 · 0 comments
Open

[Bug]: Using cached/stale fee rate and block header data causes lightning issues #2352

Jasonvdb opened this issue Nov 15, 2024 · 0 comments
Assignees
@limpbrains
Labels
bug Something isn't working triage This issue needs to be looked over by the team

Comments

@Jasonvdb
Copy link
Collaborator

Jasonvdb commented Nov 15, 2024 •
edited
Loading

Describe the bug

To startup LDK we need latest fee rates and block headers.

Beignet can fail and display no error, just return last cached data: https://github.com/synonymdev/beignet/blob/84911083a01013aa769ba91f89ff326f1f5576e8/src/wallet/index.ts#L479C7-L482C49

This can cause LDK to assume it has the latest data when it does not so payments fail and possibly channels force close.

We should not attempt to start LDK with stale data, rather handle errors/retries in Beignet or show network connection issue notification in Bitkit.
@Jasonvdb Jasonvdb added bug Something isn't working triage This issue needs to be looked over by the team labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@limpbrains limpbrains

Labels
bug Something isn't working triage This issue needs to be looked over by the team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@limpbrains @Jasonvdb