Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIF and IAF classes can output values below min_v_mem when not spiking #236

Open
bauerfe opened this issue May 16, 2024 · 0 comments
Open
Assignees

Comments

@bauerfe
Copy link
Contributor

bauerfe commented May 16, 2024

It is possible to instantiate the LIF and IAF classes without a spike function. In that case the membrane potentials v_mem will be used as the layer output.

When a value for min_v_mem is provided, v_mem is clipped at this value. However, currently the clipping happens after v_mem is copied to the output tensor, hence the output can be less than the defined lower limit min_v_mem.

The fix should be easy: Move this if-else-block before the spike generation block just above it.

For the ALIF layer this might also be an issue.

@bauerfe bauerfe self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant