Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't reconcile resource requests while a Promise pipeline is in-flight #279

Open
aclevername opened this issue Nov 13, 2024 · 0 comments · May be fixed by #298
Open

feat: Don't reconcile resource requests while a Promise pipeline is in-flight #279

aclevername opened this issue Nov 13, 2024 · 0 comments · May be fixed by #298
Labels
enhancement New feature or request

Comments

@aclevername
Copy link
Member

Related to #269, when a Promise is updated or the Promise pipeline is manually triggered, things in the system may change as a result of this. In #269 , it was the destination selectors. If we allow resource requests to be reconciled while this change occurring we might get odd behaviour, such as:

Promise:
  spec:
    destinationSelectors:
    - env: dev
   workflows:
     resource.configure.image: v0.1.0

Updated to:

Promise:
  spec:
    destinationSelectors:
    - env: **prod**
   workflows:
     resource.configure.image: **v0.2.0**

We could potentially end up running a resource request pipelines with image v0.2.0 and destination selectors env: dev, which is bad. Eventually the resource request would rerun with v0.2.0 and env: prod, but being this in-between state is potentially dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant