refactor: drop async_graphql engine from executing queries #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meskill
force-pushed
the
chore/remove-async-graphql-engine
branch
from
bc8b104 to
652bc31
Compare
github-actions
bot
added
ci: benchmark
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3223 +/- ##
==========================================
+ Coverage 86.41% 86.44% +0.02%
==========================================
Files 282 282
Lines 28773 28756 -17
==========================================
- Hits 24865 24858 -7
+ Misses 3908 3898 -10 ☔ View full report in Codecov by Sentry. |
karatakis
approved these changes
Dec 18, 2024
tusharmath
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ignore
enableJIToption and use only the JIT engine to execute queries. It's still possible to define this in the config but it won't affect anything.This is an initial step to drop async_graphql engine and more work should be done:
Issue Reference(s):
Fixes #3128
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>