Allow mean on both f32 and &f32 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
Since each trait 'instance' can only be implemented once for each type, we could not implement `Mean` for both `I: Iterator<Item = f32>` and `Item = &f32`, as the `I` could technically be the same. This patch rewrites it to instead of taking an Input type parameter to differentiate the traits, and takes an approach similar to `Sum` in the standard library. It also has the advantage that users could extend what can be taken a 'mean' of by implementing `Mean` themselves. Technically, this could be made a generic impl for types that implement a certain set of traits (sum + div), but that is potentially not super useful and just makes things more complicated. Signed-off-by: Marcel Müller <[email protected]>
|
Yeah, as you noted this is a breaking change which we're probably not ready to make at this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two patches are somewhat independent. The first is the 'minimal' change to allow using a Iterator<Item = &f32>`. The second is a more complete implementation, inspired by the constructs used in the standard library.
Feel free to pick either!
Fixes #121
Hm, I just realized that micromath is in 2.1 🥲 so this would not fly for a minor/patch release.
If you don't plan on releasing 3.x, it can't be implemented AFAIK. Since
Meantakes no arguments, there's only ever a single instance of it and as such can't be implemented for differingI