Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having vue-cli-plugin-tauri installed overrides npmScript, calls wrong command anyways #162

Closed
lights0123 opened this issue Aug 30, 2021 · 0 comments · Fixed by #611
Closed

Comments

@lights0123
Copy link

If npmScript is explicitly set, it should be respected, and not overridden regardless of what packages are installed. In addition to that problem, its behavior is just wrong. If vue-cli-plugin-tauri is installed, this action will always call the wrong command. If yarn is detected (which is isn't for me because of #161), it just calls yarn, which doesn't actually build anything. If it isn't detected, then it calls npx run tauri:build, which is also wrong because the NPM package run expects a path to a script, not a package.json script. This was probably intended to be npm, not npx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant