-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify action #354
Comments
i'm a bit torn about this tbh. Like i said many times i myself don't use the action and prefer manual build steps instead. The problem is just that many many users have no idea about gh action or ci in general and really only use it because there is no cross platform support. so a one-liner really is super good for them, if that one-liner works of course... Then there are some features often asked for like the latest.json generation which you can't really do outside of the action itself in a nice and noob-friendly way. The Tauri init stuff is a bit weird, but i heard often enough that core wants to keep it that i stopped caring about it - and i actually did see it used in the wild a few times. Maybe we should start with a refactor first and see if we can clean up the code base a bit before making such drastic changes, including cutting features? I started doing that a few days ago here https://github.com/tauri-apps/tauri-action/tree/refactor but didn't end up opening a PR for discussion -> this branch only turns the repo into a single package which was my main pain point working on issues here. |
Hmm I mean yeah I do see that people might get it wrong, but still. The benefits far outweigh the problems here in my opinion. |
That I think we should keep, other features could be outsourced to other github actions and we provide examples on how to integrate them. |
I honestly think we should consider making this part of the CLI even |
but the cli doesn't manage any versioning or releases, so I think it should stay on tauri-action side |
Okay so I think I actually don't know what that latest.json thingy does hahaha |
A couple months ago I rewrote this action as https://github.com/JonasKruckenberg/tauri-build and after reading some issues here, namely #342, #320, #215, #298, #192 and #215 the root issue is that our action just tries to do too much and even the fixes I implemented in my personal action wouldn't do much to alleviate this.
I propose to do this instead:
tauri-build
as a basisimplement the automatic Tauri initialisationsoftprops/action-gh-release@master
and others to replicate the functionality of the current version. The readme of my action can use as the base of this too.The text was updated successfully, but these errors were encountered: