Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Codesigning .dmg bundles strips configured dmg background #9920

Closed
macjuul opened this issue May 30, 2024 · 1 comment
Closed

[bug] Codesigning .dmg bundles strips configured dmg background #9920

macjuul opened this issue May 30, 2024 · 1 comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@macjuul
Copy link

macjuul commented May 30, 2024

Describe the bug

It appears that after CodeSigning my Tauri 2 app, the custom background configured using the new background property in the tauri.conf.json is stripped out. I believe this applies to all customisations made to the dmg bundle.

Reproduction

  • Build an app locally on MacOS. The resulting .dmg correctly has a background
  • Build an app with code signing enabled, the .dmg will now no longer have a background, and icons placed in the top left

Note that I have only tested this on GitHub CI

Expected behavior

The dmg customisation should persist after code signing. It would be a real shame if this new functionality is rendered useless because of this issue

Full tauri info output

[✔] Environment
    - OS: Mac OS 14.5.0 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.77.1 (7cf61ebde 2024-03-27)
    ✔ cargo: 1.77.1 (e52e36006 2024-03-26)
    ✔ rustup: 1.27.0 (bbb9276d2 2024-03-08)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 20.12.2
    - pnpm: 9.0.6
    - npm: 10.5.0

[-] Packages
    - tauri [RUST]: 2.0.0-beta.18
    - tauri-build [RUST]: 2.0.0-beta.14
    - wry [RUST]: 0.39.3
    - tao [RUST]: 0.27.0
    - @tauri-apps/api [NPM]: 2.0.0-beta.11
    - @tauri-apps/cli [NPM]: 2.0.0-beta.16

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace

No response

Additional context

The application is built and signed using GitHub Actions

@macjuul macjuul added status: needs triage This issue needs to triage, applied to new issues type: bug labels May 30, 2024
@FabianLars
Copy link
Member

Note that I have only tested this on GitHub CI

I assume that this is actually the issue and not code signing, see tauri-apps/tauri-action#740 - please try the workaround mentioned there. If that doesn't help i'll re-open this issue.

@FabianLars FabianLars closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

2 participants