Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename Dataset class? #6

Open
kevinyamauchi opened this issue Mar 15, 2023 · 1 comment
Open

rename Dataset class? #6

kevinyamauchi opened this issue Mar 15, 2023 · 1 comment

Comments

@kevinyamauchi
Copy link
Collaborator

Should we rename the Dataset class to something more specific. I am concerned it will be confusing when people are using it with torch due to torch.data.Dataset. Maybe something like ETDataset or TomographyDataset (too long?)?
cc @alisterburt , @LorenzLamm
@alisterburt
Copy link
Member

Yep +1 for avoiding plain DataSet

CryoETData or CryoETSample maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinyamauchi @alisterburt