Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vmap instead of list comprehension in real space projection code #56

Open
alisterburt opened this issue Jan 15, 2024 · 0 comments
Open

use vmap instead of list comprehension in real space projection code #56

alisterburt opened this issue Jan 15, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@alisterburt
Copy link
Member

libtilt/src/libtilt/projection/project_real.py

Line 76 in 958e580

images = [_project_volume(matrix)[yl:yh, xl:xh] for matrix in rotation_matrices]

@rsanchezgarc pointed out we should be able to use torch.vmap here rather than the list comprehension
@alisterburt alisterburt added the good first issue Good for newcomers label Jan 15, 2024
@alisterburt alisterburt mentioned this issue Jan 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alisterburt