Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token expiration time isn't being calculated correctly #9

Open
pogotc opened this issue Oct 28, 2019 · 0 comments
Open

Token expiration time isn't being calculated correctly #9

pogotc opened this issue Oct 28, 2019 · 0 comments

Comments

@pogotc
Copy link
Contributor

pogotc commented Oct 28, 2019

This is a bug in this line of code https://github.com/talis/talis-node/blob/f91b811565c7bf7358525b6caa4ff65ab9b6607f/persona/client/lib/generate-token.js#L46 for some reason javascript is concatenating the two numbers together instead of adding them.

Changing this to data.expires_at = parseInt(now) + parseInt(data.expires_in); seems to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pogotc