Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools_scm shouldn't be in the runtime dependency list #73

Open
yurivict opened this issue Dec 17, 2023 · 4 comments
Open

setuptools_scm shouldn't be in the runtime dependency list #73

yurivict opened this issue Dec 17, 2023 · 4 comments

Comments

@yurivict
Copy link

here

@arokem
Copy link
Collaborator

arokem commented Dec 18, 2023

Where should it go instead?

@yurivict
Copy link
Author

It should be a setup or configure dependency.

@arokem
Copy link
Collaborator

arokem commented Dec 20, 2023

That doesn't seem to work, see #75

@musicinmybrain
Copy link
Contributor

musicinmybrain commented Apr 2, 2024

The logs from the CI run on #75 have been cleaned up, so I can’t see what was going wrong.

In any case, I agree that setuptools_scm doesn’t need to be a runtime (“installation”) dependency because it isn’t imported after build.

Note that PEP517 builds should be getting the setup dependency from

requires = ["setuptools >= 42.0", "wheel", "setuptools_scm[toml] >= 3.4", "setuptools_scm_git_archive"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants