Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut buttons to push either token #39

Open
Alexander-Shukaev opened this issue Jan 2, 2022 · 3 comments
Open

Shortcut buttons to push either token #39

Alexander-Shukaev opened this issue Jan 2, 2022 · 3 comments
Assignees
Labels

Comments

@Alexander-Shukaev
Copy link

Hi, currently one has to choose each secret explicitly and then tap a corresponding button to push the respective token via USB or Bluetooth. Along with that, sensitive information is also displayed at the very first tab (including username and other login details), which is not nice if somebody looking at your screen. I would propose:

  • Display shortcut buttons to push token already in the list of secrets (for each of them);
  • Display sensitive login information only on the second tab if secret is chosen, and only buttons on the first tab.
@Alexander-Shukaev
Copy link
Author

I also noticed one bug related to a keyboard button shortcut to the right of each record. As I understood with a long press it kind of tries to do what I proposed above, but unfortunately it:

  • types wrong characters, i.e. really the resulting typed password is a little bit incorrect compared to the one being typed when explicitly going into the record and tapping "password" button (so there is inconsistency for whatever reason);
  • it does not obey the setting to type Return after password, i.e. simply ignores it for whatever reason.

@tejado
Copy link
Owner

tejado commented Jan 3, 2022

Hi @Alexander-Shukaev
thanks for the issue. Yes, indeed: the keyboard-icon is a shortcut to enter just the password. I just checked the source and yes, the default auto-type language is currently ignored by this functionaltiy, and Apple DE is hard coded for whatever reason. I have to fix it.
I also dont like the current TreeView much, e.g. due to only one shortcut button. But I did not find a better UI so far.

And from a UX perspective: you would expect that the shortcut button will follow the Return setting for this entry? I guess this would make sense as then it is consistent in the behavior.

@tejado tejado self-assigned this Jan 3, 2022
@tejado tejado added the bug label Jan 3, 2022
@tejado
Copy link
Owner

tejado commented Jan 18, 2023

OTPs are not shown anymore per default when generated over an auto-type button: fdfa38c. Clicking on the OTP field will show them.

Having a better secrets overview with additional shortcut buttons is something I have to think about.
Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants