Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when identify a wastewater node #379

Open
urskaufmann opened this issue Aug 14, 2024 · 6 comments
Open

Warning when identify a wastewater node #379

urskaufmann opened this issue Aug 14, 2024 · 6 comments
Labels
bug Something isn't working QGIS project Concern the .qgs QGIS project

Comments

@urskaufmann
Copy link
Contributor

Describe the bug
I get this warning:
WARNING Traceback (most recent call last):
File "C:\Users/KAU/AppData/Roaming/QGIS/QGIS3\profiles\tww_test/python/plugins\linking_relation_editor\gui\linking_relation_editor_widget.py", line 774, in afterSetRelations
self._checkTransactionGroup()
File "C:\Users/KAU/AppData/Roaming/QGIS/QGIS3\profiles\tww_test/python/plugins\linking_relation_editor\gui\linking_relation_editor_widget.py", line 788, in _checkTransactionGroup
connectionString = PluginHelper.connectionString(self.relation().referencedLayer().source())
AttributeError: 'NoneType' object has no attribute 'source'

To Reproduce
Exact steps to reproduce the behavior:

  1. Select 'vw_wastewater_node' (Editing status does not matter)
  2. Choose 'Identify Features' tool
  3. Click on a wastewater node
  4. See warning

Same behaviour when click on the Wastewater Nodes Tab in vw_tww_wastewater_structure

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots / data

Desktop (please complete the following information):

  • TWW version 0.0.0
  • QGIS Version 3.34.4
  • OS Win 10

Additional context

@cymed
Copy link
Contributor

cymed commented Aug 19, 2024

Looks like there is a problem with the linking relation editor plugin. What version do you use?

@urskaufmann
Copy link
Contributor Author

Linking Relation Editor

Provides a relation editor widget with an alternative link child dialog

Provides a relation editor widget with an alternative link child dialog

4 rating vote(s), 14834 downloads
Category Vector
Tags relation
More info homepage bug tracker code repository
Author OPENGIS.ch
Installed version 1.3.0
Available version (stable) v1.3.0 updated at 22.03.2024 11:08

@sjib sjib added the bug Something isn't working label Oct 3, 2024
@domi4484
Copy link
Contributor

domi4484 commented Oct 5, 2024

In QGIS, when we delete (maybe as well rename?) a relation, the corresponding relation editor widgets are not removed from the attribute forms. This is probably what happened with a relation in the table vw_tww_overflow. The relation editor widget seems configured with a non-existing relation (empty string).
@urskaufmann should be trottle_shut off unit-overflow?

image

I made a pull request for the Linking relation editor to not show a python exception but log a little more explicative warning opengisch/qgis-linking-relation-editor#51

Still this kind of issue can be hard to find. It would be good to find a solution in QGIS to warn the user about such kind of misconfiguration

@domi4484 domi4484 added the QGIS project Concern the .qgs QGIS project label Oct 5, 2024
@domi4484
Copy link
Contributor

domi4484 commented Oct 5, 2024

@ponceta maybe in the similar direction of qgis/QGIS#58973 we could propose to add a warning icon o something visual in the column Form Layout to indicate when an editor widget is configured for a no-more-existing field or a relation editor is configured for a no-more-existing relation

@ponceta
Copy link
Member

ponceta commented Oct 8, 2024

@ponceta maybe in the similar direction of qgis/QGIS#58973 we could propose to add a warning icon o something visual in the column Form Layout to indicate when an editor widget is configured for a no-more-existing field or a relation editor is configured for a no-more-existing relation

Very good idea, I open a feature request in that sense, then we look to provide an estimation of such estimations to the QGIS CH Grants.

@ponceta
Copy link
Member

ponceta commented Oct 8, 2024

See the request QGIS Side : qgis/QGIS#59001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QGIS project Concern the .qgs QGIS project
Projects
None yet
Development

No branches or pull requests

5 participants