Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement smart conditional renders #186

Open
alexnm opened this issue Apr 16, 2019 · 2 comments
Open

Implement smart conditional renders #186

alexnm opened this issue Apr 16, 2019 · 2 comments
Labels
enhancement New feature or request exploration May need some research and discussions

Comments

@alexnm
Copy link
Contributor

alexnm commented Apr 16, 2019

We had this implemented (#89 and #103) but with the new UIDL structure, this has to be thought differently. Perhaps we can have a step in the resolver that looks at boolean conditionals and decides if two conditionals which are one after another can be written in a smarter way:

  • ternary in react: { condition ? (branch - true) : (branch - false)
  • v-if/v-else in vue
@alexnm alexnm added enhancement New feature or request good first issue Good for newcomers exploration May need some research and discussions labels Apr 16, 2019
@alexnm alexnm added this to the Beta Release - v0.7 milestone Apr 16, 2019
@vladnicula
Copy link
Collaborator

Do you mean we could check UIDL and decide we can group conditionals together?

@alexnm
Copy link
Contributor Author

alexnm commented Apr 22, 2019

yes, like a step before the pipeline processing

@alexnm alexnm modified the milestones: Beta Release - v0.7, Official Release - v1.0 May 27, 2019
@alexnm alexnm removed the good first issue Good for newcomers label Jun 10, 2019
@alexnm alexnm removed this from the Official Release milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exploration May need some research and discussions
Projects
None yet
Development

No branches or pull requests

2 participants