You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
In this commit 2503b60 , you have changed getTable to getTableName. But if an user will create tables with different name in this method protected function edgeExists(): booldagEdgeModel will try to get table by class name. So you need to add getTable method to the model as it is described in Laravel API . Also as I think getTableName has no usage. And one more thing, you have edge_model in config but your methods, for example protected function createEdge(): DagEdge as you see returns DagEdge model and not contract or something like that.
Thank you!
The text was updated successfully, but these errors were encountered:
Thx for your input. It looks like you have identified a few things that need to be addressed. I just noticed and responded to your PR, which appears to fix at least one of the issues you mentioned. As noted in the PR conversation, I will try to get to that soon...as well as the other issues that you described.
Hello,
In this commit 2503b60 , you have changed
getTable
togetTableName
. But if an user will create tables with different name in this methodprotected function edgeExists(): bool
dagEdgeModel
will try to get table by class name. So you need to addgetTable
method to the model as it is described in Laravel API . Also as I thinkgetTableName
has no usage. And one more thing, you haveedge_model
in config but your methods, for exampleprotected function createEdge(): DagEdge
as you see returnsDagEdge
model and not contract or something like that.Thank you!
The text was updated successfully, but these errors were encountered: