Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTableName in DagEdge model #22

Open
dealense7 opened this issue Dec 14, 2022 · 1 comment
Open

getTableName in DagEdge model #22

dealense7 opened this issue Dec 14, 2022 · 1 comment

Comments

@dealense7
Copy link
Contributor

Hello,
In this commit 2503b60 , you have changed getTable to getTableName. But if an user will create tables with different name in this method protected function edgeExists(): bool dagEdgeModel will try to get table by class name. So you need to add getTable method to the model as it is described in Laravel API . Also as I think getTableName has no usage. And one more thing, you have edge_model in config but your methods, for example protected function createEdge(): DagEdge as you see returns DagEdge model and not contract or something like that.

Thank you!

@telkins
Copy link
Owner

telkins commented Mar 23, 2023

Thx for your input. It looks like you have identified a few things that need to be addressed. I just noticed and responded to your PR, which appears to fix at least one of the issues you mentioned. As noted in the PR conversation, I will try to get to that soon...as well as the other issues that you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants