Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade web3 and eth_abi #703

Open
akremstudy opened this issue Aug 10, 2023 · 1 comment
Open

Upgrade web3 and eth_abi #703

akremstudy opened this issue Aug 10, 2023 · 1 comment

Comments

@akremstudy
Copy link
Collaborator

There is a bug when encoding empty string using current eth_abi library, adds extra zeros to encoding, the bug is addressed when trying newer eth_abi version. But upgrading eth_abi seems to require upgrading web3 also.

@akremstudy
Copy link
Collaborator Author

There is a bug when encoding empty string using current eth_abi library, adds extra zeros to encoding, the bug is addressed when trying newer eth_abi version. But upgrading eth_abi seems to require upgrading web3 also.

update:
Actually I think just updating the code (everywhere to be safe) to use from eth_abi import encode instead of from eth_abi import encode_abi should do the trick instead of updating the package version; encode is available in the currently used version and encode_abi is being deprecated in favor of encode. same for switching decode_abi for decode.

ps: updating packages causes version conflicts between them that seem to resolve after updating pip but not sure about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant