Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish end-to-end state override tests #70

Open
guilledk opened this issue Oct 23, 2024 · 0 comments
Open

Finish end-to-end state override tests #70

guilledk opened this issue Oct 23, 2024 · 0 comments

Comments

@guilledk
Copy link

guilledk commented Oct 23, 2024

Overview

We want to build a more robust test suite for the state override system on compare function such that in the future if upstream changes logic related to this we can make sure we catch any new bugs.

Currently we have 83% coverage of compare function using mostly unit test + a single end to end test, we should try to build more variations of the end-to-end test, also making sure we test both historical and current-state calls.

Links

Compare function:

pub fn compare_state_diffs<Ext, DB>(

Current end to end test:

async fn test_integration_tevm_only() {

Acceptance Criteria

Build end-to-end tests for all override cases (try to hit all panics in compare function), and query reth state using historical and current-state rpc calls.

Tasks

###TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant