-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide sample to show per workflow interceptor instead of global #489
Comments
The interceptor is meant to be an advanced flexible thing. If you want logic that only applies to certain namespaces, or certain task queues, or certain workflow types, or certain prefixed workflow IDs, or if only a certain header is present, or whatever, then you can add that condition in your interceptor. I do not think it's necessary to have this condition built in more than any other. If a sample is needed to show how to only do something in an interceptor based on a certain condition, we can show that. |
@ktenzer - can we close this since the interceptor is already flexible enough to have different logic per workflow type, task queue, namespace, workflow ID prefix, etc? Or do you feel it's important enough that we make a special case for workflow type different from the other discriminators? |
I updated the title to just be create a sample |
@chad Retz ***@***.***> Yeah that is fine. I still think a sample
would be nice but I am not sure how many developers actually want to use it
this way. I have heard of 1 which might not be enough to justify sample.
…On Thu, Jun 20, 2024 at 1:43 PM Chad Retz ***@***.***> wrote:
@ktenzer <https://github.com/ktenzer> - can we close this since the
interceptor is already flexible enough to have different logic per workflow
type, task queue, namespace, workflow ID prefix, etc?
—
Reply to this email directly, view it on GitHub
<#489 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADK5D7CBF2WUOII3WMA5CDZIM5GBAVCNFSM6AAAAABI3GJAJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGUZDSNBWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Is your feature request related to a problem? Please describe.
Need to have different interceptor behavior per workflow
Describe the solution you'd like
Would like a clean option for having interceptor be per workflow. Currently its registered w/worker factory but the worker services multiple workflows so need option to apply interceptor to a workflow or subset of workflows.
Additional context
Per-SDK Tickets
The text was updated successfully, but these errors were encountered: