Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity failure is not encrypted with the key set to the context propagator, used to encrypt workflow and activity payload #1587

Closed
antmendoza opened this issue Aug 13, 2024 · 1 comment

Comments

@antmendoza
Copy link
Member

antmendoza commented Aug 13, 2024

Using this code as example, I have set the Failure converter with EncodeCommonAttributes to encrypt failures

c, err := client.Dial(client.Options{
...
...
FailureConverter: temporal.NewDefaultFailureConverter(temporal.DefaultFailureConverterOptions{
	EncodeCommonAttributes: true,
	DataConverter:          dataConverter,
}),

workflow and activity payload are encrypted with the key set to the context propagator but not failures.

Expected Behavior

Failure attributes should be encrypted

Actual Behavior

Failure attributes are not encrypted (or are encrypted with a different key)

Steps to Reproduce the Problem

There is a repro here and
the workflow history that it produces where encryption-key-id is empty

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Aug 27, 2024

As discussed offline this is not excepted to work because failure converters cannot be context aware. I opened up an issue to add support to failure converters #1609

@Quinn-With-Two-Ns Quinn-With-Two-Ns closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants