Ignore search attributes from GetVersion in mocks

[ndtretyak]

Expected Behavior

Search attributes from GetVersion does not affect OnUpsertSearchAttributes mock

Actual Behavior

Tests fail if UpsertSearchAttributes calls from versioning are not mocked explicitly

Steps to Reproduce the Problem

1. Use GetVersion and UpsertSearchAttribute in your workflow
2. Use env.OnUpsertSearchAttribute in a test to validate the arguments of UpsertSearchAttributes
3. Test will fail on unexpected calls to UpsertSearchAttributes made from GetVersion

[Quinn-With-Two-Ns]

Search attributes from GetVersion is intended to affect OnUpsertSearchAttributes. OnUpsertSearchAttributes is intended to be called on any upsert search attribute, which includes GetVersion. We should clarify in the docs that OnUpsertSearchAttributes will be used used for GetVersion

[ndtretyak]

When multiple GetVersion calls are present across different branches of a workflow, mocking each OnUpsertSearchAttributes becomes challenging due to the accumulation of all previous changeIDs in an unpredictable order.

Additionally, getChangeVersions is non-deterministic because it iterates over a map, and its result is used in the UpsertSearchAttributes call.

sdk-go/internal/internal_event_handlers.go

Line 926 in 8283604

TemporalChangeVersion: getChangeVersions(changeID, version, existingChangeVersions),

[Quinn-With-Two-Ns]

You shouldn't need to assert the exact value of changeID if you are not interested in it. You should be able to use something like MatchedBy to just match the key in the map.

env.OnUpsertSearchAttributes(mock.MatchedBy(func(attr map[string]interface{}) bool {

[ndtretyak]

Thanks! This is exactly what I needed.