Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deserializing typed search attributes, invalid values should be ignored #1668

Open
cretz opened this issue Oct 11, 2024 · 0 comments
Open

Comments

@cretz
Copy link
Member

cretz commented Oct 11, 2024

Expected Behavior

If a user creates a workflow or a schedule using untyped attributes and passes in a single-item array, the typed search attributes should simply not include that value.

Actual Behavior

Today, if a user creates a workflow or schedule using untyped attributes like keyword with a single-item array, it is a panic when we try to convert to typed search attributes. While it may seem like inside a workflow this panic is the users fault for accessing typed search attributes, it is not the users fault when simply describing the workflow. We might as well just ignore all invalid values. This is confirmed to be the behavior in Python (didn't confirm elsewhere).

This was most obvious when a user used the TypeScript SDK to create a schedule that has a workflow action with its search attributes as a single item array (the only form TypeScript SDK supports at this time since it lacks typed search attributes). Then the user did a temporal schedule describe in CLI which panics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant