-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erroneous extra replay command when replaying mid-workflow tasks #1670
Comments
Curious if you have any thoughts / preferences here. |
Thanks for the report! Will confer with the team on replaying of mid-task history captures. While it makes sense to only replay up to the last completed or failed task, we may need to double check that people aren't running replays on the active task without the task failure to replicate failures (e.g. to replicate deadlock detection). |
Conferred with team, we consider this a bug. If we are in fact failing a replay with history that should succeed, we need to fix. It is likely we should not be performing history matching for non-determinism checks after the last task start (that doesn't have an end). This issue will be updated when we have a solution. |
This is more of a request for information than a bug.
Expected Behavior
Replaying a downloaded workflow history ending with workflow task (started) should not fail with a [TMPRL1100] nondeterministic workflow: extra replay command
Actual Behavior
Replaying a downloaded workflow history ending with workflow task (started) fails with an [TMPRL1100] nondeterministic workflow: extra replay command
Steps to Reproduce the Problem
Reproducing test and detailed explanation: RamyElkest#1
Specifications
v1.26.0
v1.23.1
The text was updated successfully, but these errors were encountered: