From 22cac65079c5359afa50797e101ea4f6110227eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?N=C3=B3ra=20Szepes?= Date: Thu, 24 May 2018 13:10:17 +0200 Subject: [PATCH] Removed installing extra addons from afterInstall hook #14 They kept removing our addon from the node_modules/ --- README.md | 32 +++++++++---------- .../ember-mu-application-generator/index.js | 6 +--- 2 files changed, 16 insertions(+), 22 deletions(-) diff --git a/README.md b/README.md index a5eb218..b92610a 100644 --- a/README.md +++ b/README.md @@ -12,30 +12,17 @@ ember install https://github.com/tenforce/ember-mu-application-generator.git ember generate ember-mu-application-generator ``` -The ember generate is needed, because on install the application should install some necessary files (transforms, utils, etc.) and addons (ember-power-select, ember-changeset). If ember installation is done with a git url, ember install cannot find the package name and install the default blueprint (where packagename == blueprintname). -If it's needed, you can modify the url with a tag or a branch: -``` -ember install https://github.com/tenforce/ember-mu-application-generator.git#tag -ember install https://github.com/tenforce/ember-mu-application-generator.git#branch -``` - -### Ember 2.14 - -To use the addon with Ember version >=2.14 and <3.0.0, make sure to use the good tag: - -``` -ember install https://github.com/tenforce/ember-mu-application-generator.git#ember-2.14 -``` +The ember generate is needed, because on install the application should install some necessary files (transforms, utils, etc.). If ember installation is done with a git url, ember install cannot find the package name and install the default blueprint (where packagename == blueprintname). Don't forget to install the dependencies too! ### Dependencies This addon requires the following addons: - [ember-power-select](https://github.com/cibernox/ember-power-select) - [ember-changeset](https://github.com/DockYard/ember-changeset) -- [ember-datetimepicker](https://github.com/kellyselden/ember-datetimepicker) +- [ember-datetimepicker](https://github.com/kellyselden/ember-datetimepicker) The `ember-datetimepicker` addon needs `jquery-datetimepicker`. -If they are not installed with the `ember generate ember-mu-application-generator`, then please install them manually. +They are not installed with the `ember generate ember-mu-application-generator`, please install them manually. ``` ember install ember-power-select @@ -43,8 +30,19 @@ ember install ember-changeset ember install ember-datetimepicker ``` -The ember-datetimepicker addon needs jquery-datetimepicker to be able to run. Somehow the addon doesn't ember install it correctly, so make sure to use `ember install ember-datetimepicker` command! +### Different version +If it's needed, you can modify the url with a tag or a branch: +``` +ember install https://github.com/tenforce/ember-mu-application-generator.git#tag +ember install https://github.com/tenforce/ember-mu-application-generator.git#branch +``` + +### Ember 2.14 +To use the addon with Ember version >=2.14 and <3.0.0, make sure to use the good tag: +``` +ember install https://github.com/tenforce/ember-mu-application-generator.git#ember-2.14 +``` ### Design installation diff --git a/blueprints/ember-mu-application-generator/index.js b/blueprints/ember-mu-application-generator/index.js index 93744b3..f95356c 100644 --- a/blueprints/ember-mu-application-generator/index.js +++ b/blueprints/ember-mu-application-generator/index.js @@ -12,11 +12,7 @@ module.exports = { // to install important packages afterInstall: function(options) { - updateRouter.call(this, 'add', options); - this.addPackageToProject('jquery-datetimepicker', '^2.5.4'); - this.addAddonToProject('ember-power-select', '^1.9.3'); - this.addAddonToProject('ember-datetimepicker', '^2.1.0'); - return this.addAddonToProject('ember-changeset', '~1.3.0'); + return updateRouter.call(this, 'add', options); }, afterUninstall: function(options) {